Hi. Your post is useful, thanks. I have gone through points that you have made and added my comments.


retrieve_ESLIM_codes uses the global variable $dbh

Should I be calling the database from within each subroutine, seperately?


retrieve_ESLIM_codes returns @sorted_parameters_A but the return result is not used

I was planning to use this at a future point. Anyway this is a useful reminder thanks.


look_through_file uses and updates $continue_tag, but the result is not used

It is supposed to be used. When the end of file is reached the $continue_tag goes to "FALSE" and this gets passed out of the subroutine from which point the while loop (that makes the subroutine calls in the first place) is broken.


look_through_file populates a local @array_of_lines, but the result is not used

Again. This will be used at a future point. Although I did not correctly build this array (as hinted in your next point).


look_through_file sets a local $entry_no_new, but the result is not used

At one point I did not correctly use this variable. I have removed this incorrect use. However, I don't believe that you are correct in saying that the result is not used. Basically the code is saying that if you get to the next entry number then exit the subroutine.


create_output is passed parameters that have no value

I'm not sure if I understand what you are suggesting here. Is this problem covered in the other posts?

---

---

• Are you posting in the right place? Check out Where do I post X? to know for sure.
• Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:

  <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>

• Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
• Want more info? How to link or How to display code and escape characters are good places to start.