I see what you mean, that this is a "dangling else" clause.
I guess something like:
$trimmedcolr = $colr;
$trimmedcolr = 'BB' if $colr eq 'baby blue';
$trimmedcolr = 'BP' if $colr eq 'baby pink';
$trimmedcolr = 'DB' if $colr eq 'dark blue';
$trimmedcolr = 'DP' if $colr eq 'dark purple';
$trimmedcolr = 'HP' if $colr eq 'hot pink';
$trimmedcolr = 'LP' if $colr eq 'light purple';
would have worked although the hash based solutions in this thread are probably more efficient. BTW, I have no problem with this trailing "if" syntax in a situation like this were the intent and readability is very clear.
The "why" question wasn't asked. However since Perl is so good at processing strings, I would suggest that translating an easily understandable string into a shorter more cryptic string is usually just not necessary or advisable.
I would not do this translation without a good reason. One reason might be that this program talks to something else that only understands the two letter abbreviations, however in that case, the default of not abbreviating the color doesn't appear to make sense. Making this a subroutine and returning an error in the case of an unknown color might make sense. I don't know what this "abbreviate it if you can" idea accomplishes.
Without a good reason, I wouldn't do this, but consider this:
my @colors = ( 'baby blue', 'baby pink',
'dark blue', 'dark purple',
'hot pink', 'light purple',
'wild green', 'crazy yellow',
'wild crazy purple', 'deep purple');
# The translation algorithm appears to be straight-
# forward, so a table independent translation is
# possible ... Of course 'dark purple' and 'deep purple'
# would translate into the same thing, but maybe that is
# ok? This is application dependent.
my $color = shift; #like: 'wild crazy purple'
$color = uc $color;
my @FirstCaps = $color =~ /(\w)\w+/g;
return @FirstCaps; #like: WCP
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.
| & || & |
| < || < |
| > || > |
| [ || [ |
| ] || ] ||