I'd rather see that sort routine inlined in this case. As it stands, nasty subtle bugs can creep in with some sloppy maintenance. Say at some point someone has to add $VAR2 and perform similar sorting on it... and make the all too simple mistake of thinking they can add a line that reads:
my @result2 = sort custom keys %$VAR2;
Oops. And that's just one example.
This is perfectly readable:
my @result = sort {
$VAR1->{$a}{network} cmp $VAR1->{$b}{network}
} keys %$VAR1;
If it was something you had to do repeatedly, it would be better to wrap the whole sort in a sub...
sub keys_sorted_by_network {
my $h = shift;
sort { $h->{$a}{network} cmp $h->{$b}{network} } keys %$h;
}
my @result = keys_sorted_by_network($VAR1);
-sauoq
"My two cents aren't worth a dime.";
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|