A more "Perl-ish" way of doing the same thing...
use strict;
use warnings;
use Term::ANSIColor;
use autodie;
#Program to find motif site in a given protein sequence using files
my $motif = "AGGGGG";
open( my $read, "<dna.txt" );
my @e = <$read>;
$_ = join( " ", @e );
s/\s+//g;
my @c;
push @c, pos( ) - length( $motif ) + 1 while /$motif/g;
s/$motif/color( 'bold green' ) . $motif . color( 'black' )/eg;
print $_, "\n";
print "Number of sites the motif (AGGGGG) is present: ", scalar @c, "\
+n";
print "And the positions in the string are: ", join( ',', @c ), "\n\n"
+;
The eliminates counting characters one at a time, as in the $i loop in the original, in favor of using pattern matching on the entire character string. I have found that eliminating loop counters wherever possible greatly reduces the number of bugs in my code.
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|