comment on

If you then single quote your s/// expression to protect from shell interpolation

Adding single quotes does not protect from shell interpolation.

That will fail if $hash1 or $hash2 can contain «'», I don't think that's possible, but I don't know for sure.

That's why I use

   $s =~ s/'/'\\''/g;
   return "'$s'";
[download]

instead of

   return "'$s'";
[download]

Update: philipbailey has since pointed out that the hash cannot contains quotes. While you can't context text to a shell literal using the second snippet in general, it appears to be safe in this particular circumstance.

In reply to Re^2: Find and replace MD5 hash from file by ikegami
in thread Find and replace MD5 hash from file by adroc

Are you posting in the right place? Check out Where do I post X? to know for sure.
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
Want more info? How to link or or How to display code and escape characters are good places to start.


good chemistry is complicated, and a little bit messy -LW
	PerlMonks