Oh, also your technique to find the second occurrence of something and do something to it is a bit strange. You could use the search /g in a loop and have normal code rather than the inside of evaluated replacement. But, you can locate the second occurrence directly and not need that kind of code.

You want to insert something just before the second </div>, right? Something like this (untested!):

my $replacement= '\t<?php include(\$_SERVER['DOCUMENT_ROOT'].\"\/inclu
+des\/footer.php\"); ?>\n\n';

s{ </div> .*? \K (?=</div>) }
 { $replacement }
 x;
[download]

Note that you don't use /g so don't keep checking all the rest of the divs, and you don't use $1 or anything in the replacement but "insert" it without replacing any of the stuff used to find that spot.

The \K means that what came before is just context and not included in what gets replaced. The (?=pattern) does the same for what follows. Nothing is "in" the region replaced. See also the use of lazy quantifiers.

The whole program becomes:

#!/usr/bin/perl
use strict;
use warnings;

$^I = ".bak";  # same as -i option
undef $/;   # slurp whole files!

my $replacement= '\t<?php include(\$_SERVER['DOCUMENT_ROOT'].\"\/inclu
+des\/footer.php\"); ?>\n\n';
my $filecontents;
while (defined ($filecontents=<>)) {
   $filecontents =~ s { </div> .*? \K (?=</div>) } { $replacement } x;
   print $filecontents;
   }
[download]

I added comments and changed the name of the variable from $line because nobody else noticed that this is not a single line. As written, it was confusing and hard to read because of built-in assumptions people make about idioms and style.

---

---

• Are you posting in the right place? Check out Where do I post X? to know for sure.
• Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:

  <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>

• Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
• Want more info? How to link or How to display code and escape characters are good places to start.