Beefy Boxes and Bandwidth Generously Provided by pair Networks
Welcome to the Monastery
 
PerlMonks  

comment on

( [id://3333]=superdoc: print w/replies, xml ) Need Help??

Very neat program bikeNomad. I spotted some minor bugs/optimisations ... I must remark that that was no thorough testing, so I have probably left some more things to discover for other ;-)

delete($opts{l}); ## was: delete($opts{L});

typo ... otherwise there is an infinite loop with the l-option

# was: if (/@(?:([[:word:]:]+)::)?ISA\s*=\s*(.*)\s*/) if (/(?<!\\)@(?:([[:word:]:]+)::)?ISA\s*=\s*(.*)/)

I added a negative look-behind at the beginning to not allow a backslashed '@' in front of the ISA - so now even if run on the sourcecode itself (not that this is very sensible :) it produces no errors. Furthermore I removed the '\s*' at the end, this was unnecessary as everything is ate up anyway by the (greedy) '.*' .

while (!/;/) # accumulate ISA value for multiple lines { $_ = <$f>; $tmp .= $_; } @isa = eval $tmp; # was: if ($@) { warn "Unparseable \@ISA line: $_"; next }; if ($@) { warn "Unparseable \@ISA line: $tmp"; next };

The reason for creating the eval-error can be in any of the lines read in, not only in the last. Apart from that the error handling prints now always only the part after the equal sign.

-- Hofmator


In reply to Re: Graph your Perl inheritance structure by Hofmator
in thread Graph your Perl inheritance structure by bikeNomad

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Are you posting in the right place? Check out Where do I post X? to know for sure.
  • Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
    <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
  • Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
  • Want more info? How to link or How to display code and escape characters are good places to start.
Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others contemplating the Monastery: (5)
As of 2024-04-19 23:34 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found