comment on

Hi all

I have a class that can create an object using data coming from different sources / formats. Like:

package My

sub new {
   my ($class,%args) = @_;
   my $self = bless {}, $class;

   if ($args{source} eq 'xml') {
      require My::XML;
      @ISA = qw/My::XML/;
   } elsif ($args{source} eq 'json') {
      require My::JSON;
      @ISA = qw/My::JSON/;
   }
   $self->_init(); # Versions in both My::XML and My::JSON

   return ($self);
}
# rest of methods
sub method1 { ... }
sub method2 { ... }
[download]

The packages My::XML and My::JSON:

package My::XML;

sub _init { ... }
1;

package My::JSON;

sub _init { ... }
1;
[download]

The calling code would be:

use My;

my $obj = My->new(source=>"xml");
# Do whatever with $obj
[download]

Is this a correct design to face this? Any caveat you may anticipate? Are there better alternatives?

Thank you very much in advance for your help

citromatik

In reply to Conditional inheritance strategy by citromatik

Are you posting in the right place? Check out Where do I post X? to know for sure.
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
Want more info? How to link or How to display code and escape characters are good places to start.


Your skill will accomplish what the force of many cannot
	PerlMonks