I very much like early exits ( return, next,last ) when they avoid getting deep into stuff, especially dealing with exceptions, errors, irregularities. This example allows empty lines and comments in a data file.
open my $datafile ...
LINE:
while ( my $line = <$file> ) {
next LINE unless length $line;
next LINE if ( $line =~ m{\A \s* #}xms;
process $line;
}
If you're selecting one of several possible return values, I think it better to determine the value and return it in a single place. Otherwise you have a situation where a return value of XYZ may have arisen from this return statement or from that return statement. If the blocks are more than a few lines long, it may be worth encapsulating it into a named subroutine. That way the main block is short and easy to read:
if ( option_A( $line ) ) {
$retval = do_this_complicated_thing( $line );
}
elsif ( option_B( $line ) {
retval = 'alphagetti';
retval .= ' and maple syrup'
if $option_C( $line );
}
else {
$retval = 42;
}
return $retval;
As Occam said: Entia non sunt multiplicanda praeter necessitatem.
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|