Beefy Boxes and Bandwidth Generously Provided by pair Networks
go ahead... be a heretic
 
PerlMonks  

comment on

( #3333=superdoc: print w/replies, xml ) Need Help??
Some comments on your code...
  1. # We parse the command line to pick a directory, # this is easier my $start_dir = ".";

    How is that easier then my $start_dir = shift; ???

  2. Since $id3v1 and $id3v2 are both going to be objects, the distinction between undef and 0 isn't really relevant, so you should be able to simplify about 20 lines of initialization with something like...
    $id3v1 = $mp3->{ID3v1} || $mp3->new_tag("ID3v1"); $id3v2 = $mp3->{ID3v2} || $mp3->new_tag("ID3v2");
  3. Assigning default values like this...
    $artist = "Artist of $file_name";
    ...seems like the worst possible behavior you could have as a fallback. If instead you leave the fields blank, you can at least easily identify them later and you leave it up to the application to decide what to do about it (ie: display some string like "Unknown Artist", or prompty you, or try to fetch the metadata from an external music identification site).
  4. File::Find is your friend. It's been a core module for a while now, so you don't even need to worry about installing it.

In reply to Re: Fixing mp3 tags for Android 2.0 by hossman
in thread Fixing mp3 tags for Android 2.0 by hawtin

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Are you posting in the right place? Check out Where do I post X? to know for sure.
  • Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
    <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
  • Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
  • Want more info? How to link or or How to display code and escape characters are good places to start.
Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others chanting in the Monastery: (3)
As of 2021-12-03 15:45 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?
    R or B?



    Results (29 votes). Check out past polls.

    Notices?