comment on

Just change your control flow slightly and prepare/execute the entire statement inside the if/elsif/else blocks (warning: untested code)

sub get_musings_entries {
# get musings from MySQL

my ($musing_id,$ref_id) = @_;
if($ref_id && $ref_id eq 'all') {
   $sth = $dbh->prepare(qq|SELECT musing_id, ref_id, 
                           heading,abstract, 
                           DATE_FORMAT(entry_date, '%M %e, %Y') 
                           FROM musings 
                           ORDER BY entry_date DESC|);
   $sth->execute();
}
elsif($ref_id) {
   $sth = $dbh->prepare(qq|SELECT musing_id, ref_id, 
                           heading, abstract, 
                           DATE_FORMAT(entry_date, '%M %e, %Y') 
                           FROM musings 
                           WHERE ref_id = '?'
                           ORDER BY entry_date DESC
                           LIMIT 10|);
   $sth->execute($ref_id);
}
else {
   $sth = $dbh->prepare(qq|SELECT musing_id, ref_id,  
                           heading, entry, 
                           DATE_FORMAT(entry_date, '%M %e, %Y') 
                           FROM musings 
                           WHERE musing_id = '?'|);
   $sth->execute($musing_id);
}

my $entries = $dbh->selectall_arrayref($sql_stmnt);
$sth->finish();  

return $entries;
}
[download]

In reply to Re^3: How's My Style Now? by chb
in thread How's My Style Now? by Spenser

Are you posting in the right place? Check out Where do I post X? to know for sure.
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
Want more info? How to link or How to display code and escape characters are good places to start.


Problems? Is your data what you think it is?
	PerlMonks