I'd say that the $dbh connection should remain
open for the
lifetime of the object, which means it should be created
during the constructor. You will also want to add the
DBI->connect string to the items passed to the constructor
in that case, and maybe give the option for an already
created dbi session to be passed in instead. When you have
the session, you can store it in $self->{dbh}.
As for the individual queries they should be either
created with $dbh->prepare_cached('select...');,
or stored in the object. This code may give an idea
of what I mean.
sub delete {
my $obj = shift;
my $sth = $obj->{queries}{delete} || $obj->{dbh}->prepare(
"DELETE FROM guest_list
WHERE last_name = ? and
first_names = ?" );
$sth->execute($obj->{_last_name},
$obj->{_first_names});
$obj->{queries}{delete} = $sth;
return 1;
}
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|