I was hoping you'd come by. Welcome to the Monastery.

This is 100x better. Well-done. Variable names can be improved, but I can actually scan this code and understand the basic intent. The biggest improvement now would be to skip intermediate variables that only exist once. So, something like:

use strict;
use warnings FATAL => 'all';

use List::Utils qw( sum );

my $input = do {
    local $/;
    <>;
};

my %letters;
$letters{$_}++ for grep /\w/, split //, $input;

my $total = sum values %letters;

for ( sort keys %letters ) {
    printf "%s\t%d\t%.3f\n", $_, $letters{$_}, $letters{$_}/$total;
}

print "$total characters\n";
[download]

The big differences there are:

• Removing intermediate variables
• Scoping the localization of $/
• Using a module to do the summation
• Chaining functions in the grep split.

This would be considered more "perlish". Remember - readablity also includes conciseness. This is why well-written Java is less readable than well-written Perl.

---

---

• Are you posting in the right place? Check out Where do I post X? to know for sure.
• Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:

  <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>

• Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
• Want more info? How to link or How to display code and escape characters are good places to start.