Ooh, fun! Pick apart code without worrying about hurting someone's ego ;)
my $fto = $htmDir . 'tile.htm';
# yuck: hard-coded file name in a subroutine
open(HOME,$fto);
# blargh, no error checks, are we using -T, and if not, is $htmDir
# based on user-supplied data?
foreach $section (@sections) {
# if this compiles, I guess we're not using strict, eh? ($section is
# not declared my)
#
# ... I don't even want to comment on the nastiness of the innards of
+the
# foreach loop, but I will anyway. Iterating over the hard-coded value
+s in @section, only
# to test if you are iterating over one of those values is silly code.
#
# What should have been done is to save the relevent query params to a
+ hash
# and then process each param as needed, without employing the silly c
+onditional
# logic and synthetic $contentTemp variable
#
# I also can't imagine any circumstance in which having a (.*) to gobb
+le up
# the content in $content is a good thing.
#
open(HOME,">$fto");
# again, no error checks, and no locking.
MeowChow
s aamecha.s a..a\u$&owag.print
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|