I'm writing a module that, from the constructor, will accept essentially named parameters, and I'm wondering which of the two common ways of doing so is preferred.
Should I accept a single argument of a hashref:
# new MyModule({arg1 => 'val1', arg2 => 'val2'})
sub new {
my $class = shift;
croak('oh crap!') if ref($_[0]) != 'HASH'
my %args = %{$_[0]};
}
Or should I cast all arguments into a hash:
# new MyModule(arg1 => 'val1', arg2 => 'val2')
sub new {
my $class = shift;
croak('oh crap!') if @_ % 2;
my %args = @_;
}
I've seen both techniques used in many places, but which one is generally preferred and/or considered better API design?
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|