Sure.
#!/usr/bin/perl -w
use strict;
Always use -w and use strict.
my $textfile = "iwn.txt";
Use my to declare variables under use strict.
open TEXT, $textfile or die "Can't Open $textfile";
my ($email, $id);
while (<TEXT>){
$email ||= $_ if /Email address:/;
$id ||= $_ if /Message-Id:/;
}
You were using C style looping. Perl loops are much nicer.
$x ||= $y (or equals) is the same as $x = $x || $y. The end effect for you is $id gets a value only if it doesn't already have one.
close TEXT;
print $email;
print $id;
Pulling these variables out of the loop ensures they only get printed once.
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|