Beefy Boxes and Bandwidth Generously Provided by pair Networks
The stupid question is the question not asked
 
PerlMonks  

comment on

( [id://3333]=superdoc: print w/replies, xml ) Need Help??

There are a few things I'd do differently, first the open I'd write as

open my $FH, '<', $file or die "Can't open $file: $!\n";
  • The lexical file handle $FH is limited is scope to just the block of code it appears in so won't clobber file handles opened else where. Probably not a concern for a short script but it still a good habit.
  • The three argument form of open where the open mode is specified separately is safer especially when $file comes from an untrusted source.
  • I use low precedence or so I can get rid of the brackets
  • I put $! in the error message so I know why the open failed.

The loop I'd rewite as this

use Data::Dumper; my @arr; while (<DATA>) { chomp; push @arr, $1 if m{^ +\s+(//.*)}; } print Dumper \@arr; __DATA__ // humpty dumpty // sat on a wall -// eating her curds and whey // humpty dumpty // had a great fall
which produces
$VAR1 = [ '// humpty dumpty', '// sat on a wall', '// humpty dumpty', '// had a great fall' ];
Just a couple of points
  • I use m{ } to avoid the leaning toothpicks.
  • I use capturing parentheses to grab the bit of string I want, if there is a match it is in $1 and it is pushed onto the array


In reply to Re: Help in reading log file by hipowls
in thread Help in reading log file by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Are you posting in the right place? Check out Where do I post X? to know for sure.
  • Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
    <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
  • Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
  • Want more info? How to link or How to display code and escape characters are good places to start.
Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others chanting in the Monastery: (3)
As of 2024-04-19 15:32 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found