So I would say that any code that *sets* $_ is, by definition, wrong.

Unnecessary, perhaps, but not wrong. Setting $_ can be useful:

1. As a topicalizer in a single-item for loop, to make a series of operations on a common value read more cleanly.

   Instead of this:

   $h->{foo}{bar} =~ s/[._]/ /g;
   Some::Custom::Function($h->{foo}{bar});
   $h->{foo}{bar} =~ s/^\s+//;
   $h->{foo}{bar} =~ s/\s+$//;
   $h->{foo}{bar} =~ s/`/'/g;
   [download]

   You can write this:

   for ($h->{foo}{bar}) {
       s/[._]/ /g;
       Some::Custom::Function($_);
       s/^\s+//;
       s/\s+$//;
       s/`/'/g;
   };
   [download]

2. And the occasional weird circumstance, like conveniently modifying the values of a hash:

   map { $_ = foo( $bar, $_ ) } values %somehash;
   [download]

On the other hand, where real for loops are concerned, I find it reduces confusion to always provide your own lexical topic (e.g.  for my $key (@keys) { ... } ). A bit backwards from the way the language is designed, I suppose.

---

---

• Are you posting in the right place? Check out Where do I post X? to know for sure.
• Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:

  <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>

• Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
• Want more info? How to link or How to display code and escape characters are good places to start.