There room for a some small improvements.
- You don't check the result of $dbh->prepare.
- You don't check the result of $dbh->fetchrow_array.
- Your loop can be replaced with $sth->fetchall_arrayref.
- You can also condense the code further using $dbh->selectall_arrayref.
use strict;
use warnings;
use DBI ();
use HTML::TableTiler ();
my $dbh = DBI->connect("DBI:mysql:project")
or die "Can't connect to Oracle database: $DBI::errstr\n";
my $matrix = $dbh->selectall_arrayref("SELECT * FROM modules");
die "Unable to fetch query results: $DBI::errstr\n" if $dbh->err;
my $tt = HTML::TableTiler->new();
print $tt->tile_table($matrix);
Update: I was obviously tired! Fixed the problems identified in replies.
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|