grep() won't do anything bad to @_, but I am personally against doing two operations in a row like you did that are complements.
That being said, I'd rewrite the @_-filtering line as:
my %args;
push @{ $args{ref($_) eq 'HASH' ? 'opt' : 'ext'} }, $_
for @_;
Or, I might even do a moving- splice() trick:
sub import {
my $self = shift;
my ($i,$j,@options);
for (@_) {
if (++$j, ref($_) eq 'HASH') {
push @options, splice(@_, $j + --$i, 1);
$_ = $_[$j+$i], redo if $j + $i < @_;
}
}
# handle @options
# @_ now only holds elements which aren't hash refs
$self->SUPER::import(@_);
}
</code>
japhy --
Perl and Regex Hacker
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|