Beefy Boxes and Bandwidth Generously Provided by pair Networks
Don't ask to ask, just ask
 
PerlMonks  

comment on

( [id://3333]=superdoc: print w/replies, xml ) Need Help??

There is a lot you can do to make your code better, as shown below. Note that this will not make your code faster.

  • Localize your variables (using my).
  • Localize file handles too, after making them lexicals. (Now that they're scoped, close is no longer needed.)
  • Use strict to make sure your variables are localized.
  • Use warnings to detect errors.
  • Don't open four files when you only need to open one or two.
  • Indent properly.
  • Use the safer 3-arg open.
  • Don't hardcode the area codes.
  • Don't use regexp to search for strings. Use index for a great speed boost.
use strict; use warnings; use File::Spec qw( ); use IO::Dir qw( ); my $dir = 'E:\\Documents and Settings\\ebrine'; my $cell = File::Spec->catfile($dir, 'Cell.txt'); my %area_codes = map { /(\d+)/; $1 => File::Spec->catfile($dir, $_) } grep /^\d+\.txt\z/i, IO::Dir->new($dir)->read(); my $num; ... Tk code ... sub search { my $found = 0; my @number = split(/-/, $num); my $search_text = join '', @number; my $file = $area_codes{$num[0]}; if (defined $file) { open(my $fh, '<', $file) or die("Unable to open file for areacode $num[0]: $!\n"); $found = search_file($fh, $search_text); } if (not $found) { open(my $fh, '<', $cell) or die("Unable to open file for cellphones: $!\n"); $found = search_file($fh, $search_text); } ... Show results ... } sub search_file { my ($fh, $search_text) = @_; while (<$fh>) { return 1 if index($_, $search_text) >= 0; ... Update ticker ... } return; }

In reply to Re: Searching text files by ikegami
in thread Searching text files by SteveS832001

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Are you posting in the right place? Check out Where do I post X? to know for sure.
  • Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
    <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
  • Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
  • Want more info? How to link or How to display code and escape characters are good places to start.
Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others examining the Monastery: (5)
As of 2024-04-19 07:40 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found