Beefy Boxes and Bandwidth Generously Provided by pair Networks
Perl Monk, Perl Meditation
 
PerlMonks  

comment on

( [id://3333]=superdoc: print w/replies, xml ) Need Help??
You seem to be missing at least two close curly brackets, one after the while loop and one after the if statement before the alarm.

You return undef on error, so the final statement might be better written as:
print "Collected $file (rc=". (defined $rc?$rc:'undef') . ")\n";
You are mixing stdout (bare print) and stderr (die) messages. I suggest you only print error messages to stderr, use print STDERR, or warn, or incorporate into the die statement that follows.

Your while loop could be simplified in a number of ways. For example:
while (my $line = <FILE>) { chomp $line; push @$outref, $line; # for test purposes - make it timeout! sleep 5; $outbytes += length($line); if ($outbytes >= $g_max_file_size) { warn "Maximum file size reached after $outbytes bytes"; last; } }

Assuming I put the close braces in the right place.
Another approach might be to avoid the loop altogether by testing the file size before you start reading:
my $file_size = -s IFILE; die "$file too large at $file_size bytes" if $file_size > $g_max_fi +le_size; @$outref = <IFILE>;


In reply to Re: file read timeout by cdarke
in thread file read timeout by 0xbeef

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Are you posting in the right place? Check out Where do I post X? to know for sure.
  • Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
    <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
  • Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
  • Want more info? How to link or How to display code and escape characters are good places to start.
Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others musing on the Monastery: (8)
As of 2024-04-18 16:45 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found