Beefy Boxes and Bandwidth Generously Provided by pair Networks
"be consistent"
 
PerlMonks  

comment on

( [id://3333]=superdoc: print w/replies, xml ) Need Help??
Hi madtoperl,

A number of suggestions, actually...

  1. You should use "strict" and "warnings".
  2. You should use the 3-arg form of open.
  3. You should check for failure conditions, such as open failing, or @ARGV not being set.
  4. If you use the module FileHandle, your filehandles don't have to be typeglobs.
  5. It is redundant to do ($_ =~ /.../); instead just do (/.../).
  6. If you use regex captures, you don't have to split afterwards.
  7. You're not using $changeflag; get rid of it.
  8. Finally, you're writing every line to the file, so why not just do a regex substitution and, if it fails, write the line anyway?
  9. It's considered good form (though not technically necessary in this case) to close your files when you're done with them.

Here's my rewrite:

#!/usr/bin/perl -w use strict; use warnings; use FileHandle; (my $argact = shift) or die "Syntax: $0 <fileid>\n"; my $input = new FileHandle; my $newfile = new FileHandle; open($input, "<", "one.txt") or die "Failed to read 'one.txt' ($!)\n +"; open($newfile, ">", "output") or die "Failed to write 'output' ($!)\n +"; while(<$input>){ s/^Authentication\s+number\s+is\s+(\d+)/Authentication number is $ +argact/; print $newfile "$_"; } close $input; close $newfile;

Isn't that a lot cleaner?


s''(q.S:$/9=(T1';s;(..)(..);$..=substr+crypt($1,$2),2,3;eg;print$..$/

In reply to Re: File modification by liverpole
in thread File modification by madtoperl

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Are you posting in the right place? Check out Where do I post X? to know for sure.
  • Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
    <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
  • Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
  • Want more info? How to link or How to display code and escape characters are good places to start.
Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others sharing their wisdom with the Monastery: (9)
As of 2024-03-28 12:24 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found