Your code has variables that can be (accidently!) used outside of the necessary scope. This is dangerous.

Yes, but it's good to realize that "use strict" doesn't magically fix that. Accidently using variables outside of the necessary scope happens when variables are defined using a scope that's too broad. It's pretty hard to accidently use variables from a different package - you would have to explicitely point to that package. Problems are cases like:

$var = "whatever";
sub foo {
    ...
    while ($var = <HANDLE>) {
        ...
    }
    ...
}
sub bar {
    ...
    foo();
    ... code assuming $var is unmodified ...
}
[download]

Slapping a use strict; on top of the code, and putting a my in front of the first occurance of $var doesn't solve this problem - although it makes use strict very happy.

What does solve the problem is declaring a lexical variable my $var, or a local value local $var inside foo(), neither of which actually requires use strict.

use strict is a tool. It ain't no magical bullet.

---

---

• Are you posting in the right place? Check out Where do I post X? to know for sure.
• Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:

  <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>

• Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
• Want more info? How to link or How to display code and escape characters are good places to start.