comment on

Personally, it makes a lot of sense. Sure if there's no need to chomp a value then it shouldn't hurt. However the function *must* be assuming the input it to be modifyied in some way otherwise you'd not pass a value to it that you expect to be modified.

sub modify {
   chomp( $_[0] );
   # whatever else happens, you've just potentially modified $_[0]
}

modify('fred');
# What would you expect to happen to 'fred'?

my $f ="fred\n";
modify($f);
print $f;
#fred
[download]

sub modify2 {
   # Create a copy of the input
   my $input = $_[0];
   chomp($input);
}

modify('fred');
# works now because we're not modifying the input, but a copy of it.

my $f ="fred\n";
modify($f);
print $f;
#fred\n
[download]

Cheers!
Rick
If this is a root node: Before responding, please ensure your clue bit is set.
If this is a reply: This is a discussion group, not a helpdesk ... If the discussion happens to answer a question you've asked, that's incidental.

In reply to Re: Should chomping a constant always raise an error? by BigLug
in thread Should chomping a constant always raise an error? by BrowserUk

Are you posting in the right place? Check out Where do I post X? to know for sure.
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
Want more info? How to link or How to display code and escape characters are good places to start.


XP is just a number
	PerlMonks