I believe
Fletch is right about the NULLs. The "concatentation" in your error message comes from interpolating the results into the string in this line:
print FILE ">$giName $gssName $definition\n$sequence";
One easy way to turn undef's into reasonable values is this idiom:
$giName ||= " ";
I don't see a lot to optimize, but here are my suggestions:
# makes array interpolate with newlines
local $" = "\n";
# Pull my variable declarations outside the inner loop.
my ($giName, $gssName, $definition, $sequence, @seq);
while (($giName, $gssName, $definition, $sequence) = $sth2->fetchro
+w_array )
{
$sequence = uc( $sequence );
# If I'm right about your data, you just want to
# turn the whitespace into newlines.
# The following should be faster.
@seq = split /\s+/,$sequence;
# For any fields that can be null:
$giName ||= " ";
# Less interpolation will be faster, but we need it
# for the array.
print FILE ">",$giName," ",$gssName," ",$definition,"\n","@seq",
+"\n";
}
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.