Beefy Boxes and Bandwidth Generously Provided by pair Networks
Welcome to the Monastery
 
PerlMonks  

comment on

( [id://3333]=superdoc: print w/replies, xml ) Need Help??
I've written a small script which uses a module called Config.pm to read a set of global constants as config file parameters. (Why invent a new config file syntax when you can use what PERL already provides, right?). This works fine. But I want the config file constants available to all the modules in my application. But I can't get this to work. My config module, Audit::Config.pm follows:
# full path to hosts file use constant HOSTS_FILE => '/home/csssec/audit/css_hosts.txt'; # full path to local host binary use constant HOST_BIN => '/usr/bin/host'; ... 1;
Here's the script I'm using to test:
#!/usr/bin/perl -w use strict; use Audit::Config; use Check::DNSCheck; # for every host in the hosts file open(FILE, HOSTS_FILE) || die("$!\n"); while (<FILE>) { chomp($_); my $host = $_; next if ($host =~ /^(\s*)#/); my $chk = new DNSCheck($host); $chk->run(); } close(FILE);
I want Check::DNSCheck to be able to access the constants in Audit::Config as well. I've gotten this to work in a non-OO context. But I changed Check::DNSCheck to be an OO style module (with new{} sub etc) and I could no longer access the constants in Audit::Config. Check::DNSCheck code follows:
package DNSCheck; use Audit::Config; use strict; sub new { my $class = shift; my $host = shift; my $this = { host => $host, }; bless ($this, $class); } sub run { my $this = shift; my $cmd = HOST_BIN . " $this->{'host'} 2>/dev/null"; my $r = `$cmd`; if ($r !~ /has address/) { return(0); } return(1); } 1;
Running gives the following error:
Bareword "HOST_BIN" not allowed while "strict subs" in use at Check/DN +SCheck.pm line 30. Compilation failed in require at ./audit.pl line 6. BEGIN failed--compilation aborted at ./audit.pl line 6.
So Check::DnsCheck.pm obviously insn't importing the values in Audit::Config.pm, but I'm not sure why. Some insight in this would be greatly appreciated.

Is there a better way to go about this?

Thanks


In reply to Importing constants into another module by paulski

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Are you posting in the right place? Check out Where do I post X? to know for sure.
  • Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
    <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
  • Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
  • Want more info? How to link or How to display code and escape characters are good places to start.
Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others chanting in the Monastery: (9)
As of 2024-03-28 10:07 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found