highlighted several redundant areas - along the lines of 'if these preconditions are met, then it is impossible to reach this part of the code'
This bothers me a bit, or at least how you might have reacted bothers me.
While I love realizing that I've been overly cautious and have redundant checks, I also wouldn't want to be, umm, underly cautious either. There have been several times when I realized that it would be _useful_ for later code to check that earlier code hadn't mangled necessary preconditions. Read these as 'assertions'.
How _did_ you react - clean up redundancies or total removal?
--
I'm a pessimist about probabilities; I'm an optimist about possibilities.
Lewis Mumford
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|