Maybe a little explanation will help?
sub trimTo {
my( $str, $n ) = @_;
## Give back what they gave us if the nothing to do
return $str if length $str < $n;
my $lastSpace = 1 + rindex( $str, ' ', $n-3 );
## Subtracting 3 allows for adding the '...'
## rindex finds the last space preceding the position
## or -1 if it fails.
## Adding 1 means that we can test whether it found the space
+with
## if( 1+rindex...) { ...
## or supply a default value
## 1 + rindex( ... ) || $default
## It also means that we get a length that we can supply
## directly to substr without having to increment it.
substr( $str, 0, $lastSpace || $n-3 ) . '...';
## The substr( ... ) returns from the start of string
## to the first space before the postition-3 (including that space
+)
## or the first $n characters of the string.
## Combining the two avoids a temporary var.
## Tack on the '...'
}
With respect to the 'bug'. I actually consider the difference a bonus in as much as "stuff ..." indicates that there are more words that were truncated.
Whereas "stuff..." indicates that the word itself was truncated.
If you prefer the other behaviour, then this will do it.
sub trimTo {
my( $str, $n ) = @_;
return $str if length $str < $n;
my $lastSpace = 1 + rindex( $str, ' ', $n-3 );
## Truncate length allowing to always include the ' ' before '.
+..'
my $truncLen = ( $lastSpace || $n-3 ) - 1 ;
return substr( $str, 0, $truncLen ) . ' ...';
}
Examine what is said, not who speaks.
"Efficiency is intelligent laziness." -David Dunham
"Think for yourself!" - Abigail
"Memory, processor, disk in that order on the hardware side. Algorithm, algoritm, algorithm on the code side." - tachyon
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.