Beefy Boxes and Bandwidth Generously Provided by pair Networks
good chemistry is complicated,
and a little bit messy -LW
 
PerlMonks  

comment on

( [id://3333]=superdoc: print w/replies, xml ) Need Help??
So maybe because $2 from my previous regex is undef, $tmp2 becomes undef resulting in the warning.. this makes sense.

So to fix this would the 'best' solution to wrap my code in an if block:

if($tmp2){ if($tmp2 =~ m/'/){ ...

You shouldn't be even using $2 if the match that was supposed to give it a value failed. You must rework your script's logic so that $2 is only being used if the match that loaded it succeeded.

In fact, it's dangerous to simply assume that if $2 is undefined if the previous match failed. Such is not always the case. It's even dangerous to assume anything about $2 unless you KNOW that the previous match succeeded. Take a look at the following contrived snippet:

use strict; use warnings; my $string = "Hello world!"; $string =~ m/(H\w+)\s(\w+)/; # This match succeeds. print $2, "\n"; $string =~ /(\d)(\d)/; # This match fails. print $2, "\n";

And the output is:

world world

This tells us that $2, which gains a value during the first match, retains that value even though the second match failed. In other words, even though you gave the possibility for $2 to gain a new value in the second match, it retained the original value because the second match failed.

That means that it is unreliable to just assume $2 is going to be undef if the most recent match failed, because it could possibly be holding some value from a previous pattern match.

Go back to the drawing board with regards to your program's logic. ;)

Now in regards to how to avoid an "undefined" warning, just check for definedness before doing anything with it. Please note, this solution is a stopgap measure, and won't fix the underlying bug in your script. I am providing this only because you essentially asked how to do something only if a scalar holds a defined value:

my $tmp2 = $var; # Because of bad logic we don't know # if $var is defined, thus don't know if # $tmp2 is defined. if ( defined( $tmp2 ) and $tmp2 =~ m/regex/ ) { # Do your stuff. }

Enjoy! I hope all this helps...


Dave


In reply to Re: Re: Re: Use of uninitialized value in pattern match (m//) by davido
in thread Use of uninitialized value in pattern match (m//) by wolis

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Are you posting in the right place? Check out Where do I post X? to know for sure.
  • Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
    <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
  • Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
  • Want more info? How to link or How to display code and escape characters are good places to start.
Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others about the Monastery: (3)
As of 2024-04-25 22:22 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found