comment on

Ok, first to get the terminology straight, 'node' eq 'vertex' and 'edge' eq 'link'.

In your code both nodes and links have an id. Let's look at your original code:

# this marks the current vertex
$explored->{$node->{_id}}++;

foreach my $link (@{$node->{_outlinks}}) {
   # $link isa Link, so $link->{_id} is the id of the link,
   # not of the vertex!!
   $do_search->($link->{_to}) unless ($explored->{$link->{_id}});
}
[download]

Yes, your algorithm is fine, it's just the implementation that has a little bug in it. Here's my (correct) code again, this time written explicitly:

$explored->{$node->{_id}}++;
foreach my $link (@{$node->{_outlinks}}) {
   my $new_node = $link->{_to};
   $do_search->($new_node) unless ($explored->{$new_node->{_id}});
}
[download]

-- Hofmator

In reply to Re3: Depth First Search through Digraph Results in Memory Leak by Hofmator
in thread Depth First Search through Digraph Results in Memory Leak by djantzen

Are you posting in the right place? Check out Where do I post X? to know for sure.
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
Want more info? How to link or How to display code and escape characters are good places to start.


laziness, impatience, and hubris
	PerlMonks