Beefy Boxes and Bandwidth Generously Provided by pair Networks
P is for Practical
 
PerlMonks  

comment on

( [id://3333]=superdoc: print w/replies, xml ) Need Help??

Err -- whoa there. There are a few problems with this code. First off, let me clean it up a little (such as actually passing it an array with some elements in it) and feed it though with -w -Mstrict

my @array = (42,43,44,45); my $scalar1 = 1; my $scalar2 = 2; ($scalar1,$scalar2) = my_subroutine(@array,$scalar1, $scalar2); print "$scalar1 $scalar2\n"; sub my_subroutine() { my @a = @{shift()}; my $s1 = shift(); my $s2 = shift(); print "array: @a\ns1: $s1\ns2: $s2\n"; $s1 += 22; $s2 += 33; return ($s1, $s2); }

..to which perl says:

main::my_subroutine() called too early to check prototype at - line 5. Can't use string ("42") as an ARRAY ref while "strict refs" in use at +- line 9.

..which shows the two most glaring bugs in the code. First off, you've given your subroutine a prototype, which only works if your calls to the subroutine are after its declaration. If you move the subroutine to above the call, however, we discover that you're giving the wrong prototype, anyways! (Too many arguments for main::my_subroutine at - line 15, near "$scalar2)")

You're also passing in an array, and trying to treat it as an array reference in the code. That's what the second error message is telling you.

These are all vaguely fixable by changing your code to:

sub my_subroutine(\@$$) { my @a = @{shift()}; my $s1 = shift(); my $s2 = shift(); print "array: @a\ns1: $s1\ns2: $s2\n"; $s1 += 22; $s2 += 33; return ($s1, $s2); } my @array = (42,43,44,45); my $scalar1 = 1; my $scalar2 = 2; ($scalar1,$scalar2) = my_subroutine(@array,$scalar1, $scalar2); print "$scalar1 $scalar2\n";

..but don't do that, as prototypes are mostly broken and confusing. This public service announcement has been brought yo you by the letter P and the number 42.

Networking -- only one letter away from not working

In reply to Re: Re: Passing multiple data types to a subroutine by Chmrr
in thread Passing multiple data types to a subroutine by Hagbone

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Are you posting in the right place? Check out Where do I post X? to know for sure.
  • Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
    <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
  • Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
  • Want more info? How to link or How to display code and escape characters are good places to start.
Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others learning in the Monastery: (8)
As of 2024-04-23 22:01 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found