comment on

Is there a reason that you have to split the lines in the first place? That is, if the last four fileds are significant and always lumped together, you shouldn't waste time splitting and joining those fields. Also, you shouldn't loop over <DATA> more than once unless absolutely necessary. It can be expensive if the file is large.

my %seen;
while (<DATA>) {
    /^([^\|]+)\|(.*)/; # split at the first "|"
    my ($key, $value) = ($2,$1);
    next if $seen{$key};
    print "$key: $value\n";
    $seen{$key}++;
}
__DATA__
34|4|45|56|45
45|34|45|00|23
45|34|45|00|27
34|4|456|56|03
36|4|456|56|03
[download]

In reply to Re: Improvement on script needed. by asarih
in thread Improvement on script needed. by Anonymous Monk

Are you posting in the right place? Check out Where do I post X? to know for sure.
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
Want more info? How to link or How to display code and escape characters are good places to start.


There's more than one way to do things
	PerlMonks