Beefy Boxes and Bandwidth Generously Provided by pair Networks
Keep It Simple, Stupid
 
PerlMonks  

comment on

( [id://3333]=superdoc: print w/replies, xml ) Need Help??
[disclaimer: this post is sure to demonstrate my ignorance of regular expressions & substitutions]

I'd already seen vroom's Q&A node about adding commas to a number, but it seemed there ought to be an easier way. I thought that a regexp like this one would do the trick:
$number=1234567; # with commas, should be "1,234,567" $number=~s/(\d)(\d{3})\b/$1\,$2/g;
However, this code will actually change $number to 1234,567. Despite the "g" on the end of the regexp, it still sort of works from beginning-to-end, so it only inserts the comma at the end.
Then I thought, "well, I could do this once for each comma" which would work like this:
while($number=~s/(\d)(\d{3})\b/$1\,$2/g){ # nothing here -- how silly is this? }
So then, obviously, the while loop continues as long as the substitution was successful. But is this terribly silly? Could my same code be modified slightly to work correctly with ONE simple substitution? Or am I simply better off using vroom's sub at the aforementioned node?

In reply to regexp for adding commas to a number by Kozz

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Are you posting in the right place? Check out Where do I post X? to know for sure.
  • Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
    <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
  • Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
  • Want more info? How to link or How to display code and escape characters are good places to start.
Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others contemplating the Monastery: (4)
As of 2024-03-28 20:55 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found