comment on

Some things I found...

2. You are using $CONTROL = $data[2] when you do the split but in your $sth statement you try to select where control = $Control $CONTROL does NOT equal $Control.

3. Your logic seems a little confusing, you are saying in the unless($matches) { that if you get no matches you will then update. That seems backwards what can you update if you get NO match and if you DO get a match you will then insert..?

4. As Enlil says you disconnect before you run the do

Some good node can be found here at the Monastery talking about SQL queries etc here are a few I found interesting

Problem with code - This one looks similar to yours
Re: What are placeholders in DBI, and why would I want to use them?
DBI Placeholders

Added: You also might like to change

if (-e  "v:/tf_out.txt")
{
      }
 else
 {
       die "File does not exist\n";
     }
[download]

to something like

unless (-e "v:/tf_out.txt") { die "File does not exist\n"; }
[download]

-----
Of all the things I've lost in my life, its my mind I miss the most.

In reply to Re: Errors in Code by AcidHawk
in thread Errors in Code by SamueD2

Are you posting in the right place? Check out Where do I post X? to know for sure.
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
Want more info? How to link or How to display code and escape characters are good places to start.


No such thing as a small change
	PerlMonks