Beefy Boxes and Bandwidth Generously Provided by pair Networks
"be consistent"
 
PerlMonks  

comment on

( [id://3333]=superdoc: print w/replies, xml ) Need Help??

Well one shorter would be to use grep instead of the foreach @cont.

my @contents = grep { /^[Bb].+.txt$/ } @cont;

Also you probably want your RE to be:

/^[Bb].+\.txt$/

So that is only matches a file ending in .txt rather than the current match which would match 'Bobtxt' or 'Bob.txt'

Also I don't see any point in opening the log files since you are only printing the name out anyway. You can remove the open and close for a big speedup. If you want to print the contents of the logfiles you might try:

open(FILE, "<$logfile"); # specify read explicitly with < print "$logfile:\n"; print while(<FILE>); close(FILE);

This will print the name of the file followed by its contents.

Update: Also the [B|b] is not desired as it tries to match B or | or b and you probably just want B or b which the RE's provided will match. The | character in a grouping (not a char class) provides a way to alternate groups of characters like (abc|def)ghi which would match abcghi or defghi but not aecghi etc.


In reply to Re: how do I shorten code by dga
in thread how do I shorten code by dbrock

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Are you posting in the right place? Check out Where do I post X? to know for sure.
  • Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
    <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
  • Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
  • Want more info? How to link or How to display code and escape characters are good places to start.
Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others goofing around in the Monastery: (5)
As of 2024-04-16 22:47 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found