Aha! The problem there is that the $ref lives within the lexical scope of the while loop in the bar() sub. So once the while loop exits, $ref is no longer in scope. Even if it were declared about the while loop it would fall out of scope when bar() exits. What you probably intended was something like this

sub foo {
    ...

    ## get $ref back from bar()
    my($ref, %locations) = &bar($dbh);

    ...
  
    my $location_text = $locations{$ref->{'location'}};
}

sub bar {
    ...

    my $ref;
    while ($ref = $sth->fetchrow_hashref())
    {
        my $id = $ref->{'id'};
        my $location =  $ref->{'location'};
        $locations{$id} = $location;
    }

    $sth->finish;

    ## return $ref back to caller
    return $ref, %locations;
}
[download]

However now $ref only contains the hash ref from the last iteration of the while loop, or is that the desired result?
HTH

_________
broquaint

---

---

• Are you posting in the right place? Check out Where do I post X? to know for sure.
• Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:

  <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>

• Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
• Want more info? How to link or How to display code and escape characters are good places to start.