This is an example of why the best Perl books say we should stick with Lincoln Stein's CGI module rather than try to write this ourselves.

The above code, aside from reinventing the wheel, has a variety of problems. The most immediately obvious one is the following section of code:

foreach $form (@form_data){
    (my $one, my $two) = split(/=/, $form);
    if ($one =~ m/\+/){
        $one =~ s/(\+)/" "/eg;
    }
    if ($two =~ m/\+/){
        $two =~ s/(\+)/" "/eg;
    }
    $one =~ s/%([\da-fA-F][\dA-Fa-f])/pack("C", hex($1))/eg;
    $two =~ s/%([\da-fA-F][\dA-Fa-f])/pack("C", hex($1))/eg;
    $form{$one} = $two;
    $params{$one} = $two;
}
[download]

This code is duplicated! It should be a subroutine.

If you are going to reinvent the wheel, you should only do so when you are really comfortable with the language in question. Otherwise, these problems creep in and later down the road, when you're still using your reinventions, you'll come back to them and find they need to be rewritten to get around issues like this.

And why are the hashes %forms and %params duplicated? The way they're created above, they are identical. I could go on, but that's enough for now.

Cheers!

---

---

• Are you posting in the right place? Check out Where do I post X? to know for sure.
• Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:

  <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>

• Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
• Want more info? How to link or How to display code and escape characters are good places to start.