I assume you want to set the value if a parameter is passed or if the current value is undef, and just return the current value otherwise: sub balance_by {
my $self = shift;
my %valid_params = map {$_ => 1} ('foo',
'bar');
if (@_ or ! defined $self->{'balance_by'}) {
my $entry = shift;
$self->{'balance_by'} =
(defined $entry and $valid_params{$entry})
? $entry
: 'foo';
}
return $self->{'balance_by'};
}
I would also define your %valid_params outside of the subroutine. No need to define them each time you call the sub. Also if you want to nano-optimize your code, consider using exists to see if the key exists in valid_params instead of testing its value, like so: my %valid_params; undef @valid_params{qw(foo bar)};
...
(defined $entry and exists $valid_params{$entry})
...
Also, unless I'm mistaken, there doesn't seem to be any reason to not default your fields in the 'new' method...(unless you just wanted 'if (@_)...' in that conditional?)
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|