comment on

Security! You don't check the value of $old for dangerous characters (shell metacharacters, etc) and you do no untainting, which tells me that you don't have untaint mode on. For your safety, I encourage you to enable taint mode and check your params for "safe" characters. I suggest the following regex to start, until you can accurately pin down the dangers.

$old =~ s/[^\w]//g; #or possibly throw a warning
[download]

As for the need to move files, File::Copy is probably your best bet. If you insist on not using modules (in this or other pursuits) the module is still the best place for and answer to the question "how do I do it". After all, it's just as valid as asking us for help, and the module is the most tested solution to the problem. Study prior art! :-)

Cheers,
Erik

Light a man a fire, he's warm for a day. Catch a man on fire, and he's warm for the rest of his life. - Terry Pratchet

In reply to Re: moving files by erikharrison
in thread moving files by Anonymous Monk

Are you posting in the right place? Check out Where do I post X? to know for sure.
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
Want more info? How to link or How to display code and escape characters are good places to start.


XP is just a number
	PerlMonks