Hi Monks,

I've coded a program to print out Pascal Triangle numbers and would like to find out how the code can be improved or whether there's a more efficient way to write it.

I hope you won't laugh at my code :)

#!/usr/local/bin/perl

print "Enter number of rows...\n";

chomp (my $rows = <>);

print "You entered $rows for rows\n";

pascal($rows);

sub pascal {
  my ($rows) = @_;
  print "1\n";
  for (my $outer = 1; $outer <= $rows; $outer++) {
    my $inner = $outer;
    print "1" unless ($outer == 1);
    for ($i = 1; $i <= $inner; $i++) {
      my $denominator = factorial($i)*(factorial($inner-$i)); 
      my $pascalnum = factorial($inner)/$denominator if ($denominator 
+!= 0);
      print " $pascalnum" if ($outer > 1);
    }
    print "1\n" unless ($outer == 1);
  }
}

sub factorial {
  my ($factorial) = @_;
  my $answer = $factorial;
  while ($factorial) {
    $factorial--;
    $answer *= $factorial unless ($factorial == 0);
  }
  return $answer;
}
[download]

I look forward to your comments and suggestions on how to improve the code.

Thanks in advance.

kiat

Edit kudra, 2002-06-19 Corrected spelling in title

---

---

• Are you posting in the right place? Check out Where do I post X? to know for sure.
• Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:

  <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>

• Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
• Want more info? How to link or How to display code and escape characters are good places to start.