IMO in general grep and map shouldn't be chained together, map can do greps job without having retraverse the array.
return (map{-e "$_/$target" ? "$_/$target" : ()} @dir)[0];
And frankly why bother with map and grep at all? This is much more efficient.
sub FileFinder {
my $target=shift;
-e "$_/$target" && return "$_/$target" foreach @_;
undef
}
Oh and before the premature optimization police arrest me, remember that we are searching a filesystem (possible remote etc) here. That call to -e could take a while and if we have to do more of them than we really need to then we could end up wasting a lot of time.
Adjust the file test to your taste ;-)
Yves / DeMerphq
---
Writing a good benchmark isnt as easy as it might look.
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|