sub do_stuff
{
my $this = shift;
my $session = shift
|| die "Missing req'd Session argument";
my $cgi = shift || new CGI ();
...
}
As said, I think that's horrible.
sub do_stuff {
my ($self, $session, $cgi) = @_;
croak 'Session not optional' unless $session;
$cgi ||= CGI->new();
...
}
I call my objects $self, not $this. You can see the three arguments in a single line, instead of spread over three.
esthetics aside, here are some hard figures on efficiency (slightly reformatted)
I am starting to think that you didn't read my post, and are only commenting on the piece of code. Efficiency is important, but not more important than readability and maintainability. Whenever efficiency is important, you probably should not be using OO.
- Yes, I reinvent wheels.
- Spam: Visit eurotraQ.
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|
