This is one of those examples of things that bothers people, myself included. Three shift
s, and no use of @_ to justify it, really. Instead, you could just declare them in a single my
and be done with it, like:
my ($obj, $usr_log_file, $params) = @_;
Extra params passed by the user are discarded, as one would expect.
The reason being shift
y is annoying is because it can degenerate into nonsensical situations like this:
my $self = shift;
my $foo = shift;
$self->something($foo, "bar", shift, "shift", "foo");
my ($flob,$blarg,$kvetch) = (shift,shift);
if ($kvetch = $flob->fnordicate($blarg))
What, exactly, are the parameters to this function? You have to read and understand the entire function before it becomes clear. If this were much larger, that could be very frustrating. Unfortunately, this fictional example is not too far fetched.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.
| & || & |
| < || < |
| > || > |
| [ || [ |
| ] || ] ||