Please do not use this ptime.pl It's rather ugly perl4 code in the first place, and you only call it in one place -- and in that case (&ctime(time)) it's equivilent to scalar localtime Except that scalar localtime doesn't have any of the bugs. ;>

There are only two other things which stick out at me, both of them at least partially stylistic. For one, variables start off being undefined so the = undef part of

my ($foo, $bar, @baz) = undef
[download]

is repetitive. The only other note is that the code could be made slightly tighter by scoping the variables a little tighter. For instance, both $drive and $computer can be scoped just to the loop they're used in:

foreach my $computer (@computerlist) {
  ... # yadda yadda yadda
  foreach my $drive (@drives) {
    ...
  }
  ...
}
[download]

Other than those couple of nitpicks, the code looks to be rather handy.

perl -pe '"I lo*`+$^X$\"$]!$/"=~m%(.*)%s;$_=$1;y^`+*^e v^#$&V"+@( NO CARRIER'

---

---

• Are you posting in the right place? Check out Where do I post X? to know for sure.
• Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:

  <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>

• Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
• Want more info? How to link or How to display code and escape characters are good places to start.