Beefy Boxes and Bandwidth Generously Provided by pair Networks
Perl: the Markov chain saw
 
PerlMonks  

comment on

( [id://3333]=superdoc: print w/replies, xml ) Need Help??

You need to re-think your depth computation. You're using $c for that, but the way I see it that can't be right. You're incrementing $c for each subdirectory within a directory -- not for each level. And you're also setting it back to 1 when you find a file within the directory that's not a subdirectory.

With recursion, the typical model is to increment a depth variable on entry to the function -- not before a recursive call. That way the stack pops it back to its proper value as each recursive call returns.

I'm also not 100% comfortable with a global PARSEDIR. The way you're using it -- getting the entire file list sorted -- you should be okay. But typically, on recursion if you open the same global it will have that global setting on return; i.e., you may return from a recursive call to find PARSEDIR referring to the directory you just processed. I always local these to avoid that (since you can't my a typeglob).


In reply to Re: Recursion problems... by steves
in thread Recursion problems... by Ranna

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Are you posting in the right place? Check out Where do I post X? to know for sure.
  • Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
    <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
  • Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
  • Want more info? How to link or How to display code and escape characters are good places to start.
Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others sharing their wisdom with the Monastery: (4)
As of 2024-04-19 13:52 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found