Since he's an new programmer, I would suggest going easy. I'm going to assume no one else he works with knows Perl at all, otherwise, they wouldn't be going to the DBA's (I don't know, but you may be at one of those places that blame everything on the DBA's). I guess the best things to suggest are the most basic things such as modularization of code, declaring variables (and using meaningful variable names), encouraging him to use the full power of the CGI module (by the way, if you really need a performance boost, mod_perl may not hurt either), etc.
Of course, make sure you present it in the proper manner. If you want to do a good job politically, start with the good things in the script. Then, go through the suggestions in a non-threatening manner, suggesting changes rather than starting with "This stinks!"
Hope this helps.
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|
