Code reviews are hard. That's because it's really hard to take someone else picking at your code the first few times it happens. I've had a hard time accepting criticisms in code reviews, and I know how important it is to have them and to listen.
My advice is to think about how you would feel on the other side of the table and act accordingly. Be as nice as you can about it, or the guy will reject everything you say out of spite.
It's also a good idea for your company to invest some money into training resources for this guy. Maybe a good book about style and maintenance issues, like Code Complete. Maybe let him ride a more competent coder's coattails for a bit, doing maintenance on some solid code. I learned a lot that way.
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|
