comment on

I've been thinking about this as well, and still have more to do. I'll probably update this, but here's one thought for now.

"Using modules where appropriate" is one thing, but it can be taken too far. A lot of these programs are designed to be installed on rather broken Perl installations. That is, good luck trying to get Date::Manip installed. Or Perl 5.5.3. When they finally get 5.8, they'll realize that our fearless Borg pumpking has assimilated many useful things, but that could be another several years.

I'd dock points for reinventing wheels provided by the language or in the core library of reasonably recent versions (5.4 is reasonable). qx(date) is one thing, but I've seen programs that write files and then shell out to system grep several times.

Color me sympathetic to the people stuck on systems adminstered by the slightly-less-than legitimate operator from heck (incompetent, not evil), but I have very little mercy for people who think they write code worth sharing without even having skimmed perlfunc.

In reply to Re: Code review on script site by chromatic
in thread Code review on script site by Jazz

Are you posting in the right place? Check out Where do I post X? to know for sure.
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
Want more info? How to link or How to display code and escape characters are good places to start.


Perl Monk, Perl Meditation
	PerlMonks