Nothing really wrong that I (or anyone else it seems) can
see. Might need to see how you're calling it and what's being passed in, & how you're using what's being passed back.
But if you don't mind some nitpicking: sub find_holes {
# No need to dereference and create
# a whole new array
my $aref = shift;
# This would probably be quicker w/a for loop and
# just saving the max & min, but what the hay...
my ($low, $high) = (sort { $a <=> $b } @$aref)[0,-1];
my %isthere;
# Hash slices are quicker
@isthere{$low..$high} = ();
@isthere{@$aref} = ("yes") x @$aref;
# Grep first, sort last (fewer things to sort that way)
# (and you sorted numerically before, why not now?)
return [
sort { $a <=> $b }
grep { !$isthere{$_} } keys %isthere
];
}
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|